Update heasarc.rst #3390
Merged
Update heasarc.rst #3390
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3390 +/- ##
==========================================
+ Coverage 70.18% 70.27% +0.09%
==========================================
Files 232 232
Lines 19937 19970 +33
==========================================
+ Hits 13992 14034 +42
+ Misses 5945 5936 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Please squash and merge. Only the last two commits are relevant. Let me know if you'd prefer a cleaned-up branch. |
bsipocz
reviewed
Aug 17, 2025
CHANGES.rst
Outdated
| @@ -52,6 +52,7 @@ heasarc | |||
| - Heasarc.locate_data returns empty rows with an error in the error_message column if there are | |||
| no data associated with that row rather than filtering it out. [#3275] | |||
| - Heasarc.locate_data changed to use POST request instead of GET to accomodate large requests. [#3356] | |||
| - maxrec in Heasarc.query_region maxes out on 1e5 regardless of how it is set. Use instead an ADQL query using the TOP parameter set to something larger than 1e5. [#3390] | |||
There was a problem hiding this comment.
no need for the changelog for docs and non user facing code changes, please remove
docs/heasarc/heasarc.rst
Outdated
Comment on lines
277
to
278
| though you may find that maxrec has a hard limit of 1e5 regardless of how you set it. See `issue #3387 tracker <https://github.com/astropy/astroquery/issues/3387>`_. | ||
|
|
There was a problem hiding this comment.
no need to add xref to astroquery issue. once that one is fixed the docs can be updated.
jleagle94
force-pushed
the
patch-1
branch
2 times, most recently
from
7296f5f to
ca07e4b
Compare
|
Changelog entry removed. xref in heasarc.rst updates removed. Squashed all commits into one. |
…ropy#3387 Update CHANGES.rst -- removed changelog entry (not needed) Update heasarc.rst -- removed xref (not needed)
bsipocz
approved these changes
Aug 18, 2025
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding relevant information regarding issue #3387